Geht das schöner / kürzer ?

SiLenCa

Hallo, habe mir mal nen kleines Script gebastelt für Mouseclick. Just 4 fun zum Lernen usw. Jedoch sieht der Code nicht so schön aus. Vielleicht könnt ihr mir ein paar Vorschläger oder sogar ein paar Tips geben wie ich es verschönern bzw in Zukunft gleich besser machen kann.

Quellcode:

Spoiler anzeigen

[autoit]

#include <GUIConstantsEx.au3>
#include <SliderConstants.au3>
#include <WindowsConstants.au3>

[/autoit] [autoit][/autoit] [autoit]

Global $Mfile = @ScriptDir & "\Mouseclick.au3", $Pos, $Toogle = 0

[/autoit] [autoit][/autoit] [autoit]

; Gui -->
$Options = GUICreate("Options", 400, 190)
GUISetBkColor(0x00E0FFFF) ; will change background color
GUICtrlCreateGroup("Speed", 15, 15, 230, 70)
$label = GUICtrlCreateLabel("Speed = 45", 23, 37)
$slider = GUICtrlCreateSlider(23, 57, 200, 20, BitOR($TBS_AUTOTICKS, $WS_BORDER))
GUICtrlSetState(-1, $Gui_FOCUS)
GUICtrlSetLimit(-1, 100, 0) ; change min/max value
GUICtrlCreateGroup("Key", 15, 100, 230, 70)
GUICtrlCreateLabel("Choose the key which will get pressed.", 23, 122)
$Key = GUICtrlCreateCombo("Left", 23, 140, 75)
GUICtrlSetData(-1, "Right|Middle", "Left") ; add other item snd set a new default
GUICtrlSetData($slider, 10) ; set cursor
GUICtrlCreateGroup("Clicks", 260, 15, 125, 70)
$1Click = GUICtrlCreateRadio("1 Click", 267, 37)
GUICtrlSetState(-1, $GUI_CHECKED)
$2Click = GUICtrlCreateRadio("2 Click's", 267, 57)
$Start = GUICtrlCreateButton("Starten", 262, 105, 123, 65)
GUISetState()
;==>

[/autoit] [autoit][/autoit] [autoit]

; Führt die Funktion Test alle 10ms aus
AdlibEnable("Test", 10)
;==>

[/autoit] [autoit][/autoit] [autoit]

; Schleife für die Gui
While 1
$nMsg = GUIGetMsg()
Switch $nMsg
Case $GUI_EVENT_CLOSE
Exit
Case $Start
$Speed = GUICtrlRead($slider)
$Keys = GUICtrlRead($Key)
$1 = GUICtrlRead($1Click)
$2 = GUICtrlRead($2Click)
GUIDelete()
_getPos()
EndSwitch
WEnd
;==>

[/autoit] [autoit][/autoit] [autoit]

; Erneuert den Slider
Func Test()
GUICtrlSetData($label, "Speed = " & GUICtrlRead($slider))
EndFunc
;==>Test

[/autoit] [autoit][/autoit] [autoit]

; Wartet bis F6 Gedrückt wird und Zeigt einen TrayTip an
Func _getPos()
Do
HotKeySet("{F6}", "_Get")
HotKeySet("{ESC}", "_Exit")
TrayTip("Press" & " 'ESC' " & "to Exit.", "Press" & " 'F6' " & "to get the coordinates", 500)
Sleep(500)
Until $Toogle <> 0 ; Do schleife entstand durch einen Versuch
EndFunc
;==>_getPos

[/autoit] [autoit][/autoit] [autoit]

; Checkt alle Daten und schreibt sie in die Datei
Func _Get()
$Pos = MouseGetPos()
Sleep(1000)
$cFile = FileOpen($Mfile, 1)
If $1 = $GUI_CHECKED Then
$clicks = 1
ElseIf $2 = $GUI_CHECKED Then
$clicks = 2
EndIf
FileWrite($cFile, "MouseClick('" & $Keys & "', " & $Pos[0] & ", " & $Pos[1] & ", " & $clicks & ", " & $Speed & ")" & @CRLF)
FileClose($cFile)
Exit
EndFunc
;==>_Get

[/autoit] [autoit][/autoit] [autoit]

; Beendet das Script
Func _Exit()
Exit
EndFunc
;==>_Exit

[/autoit]

Danke schonmal an alle.

Edit: Mit schöner meinte ich "nicht" Kommentare. Die werde ich wenn der Code besser aussieht hinzufügen.

ChaosKeks

Hmm habs mal n bisschen verbessert, zwar nur bisschen verkürzt aber jetzt läuft es flüssiger ;):

Spoiler anzeigen

[autoit]

#include <GUIConstantsEx.au3>
#include <SliderConstants.au3>
#include <WindowsConstants.au3>
#include <WinApi.au3>

[/autoit] [autoit][/autoit] [autoit]

Opt("GuiOnEventMode",1)
; #GUI# =================================================================================
$Options = GUICreate("Options", 400, 190)
GUISetBkColor(0x00E0FFFF)
GuiSetOnEvent($GUI_EVENT_CLOSE, "_Exit")

[/autoit] [autoit][/autoit] [autoit]

GUICtrlCreateGroup("Speed", 15, 15, 230, 70)
$label = GUICtrlCreateLabel("Speed = 45", 23, 37)
$slider = GUICtrlCreateSlider(23, 57, 200, 20, BitOR($TBS_AUTOTICKS, $WS_BORDER))
GUICtrlSetData($slider, 45)

[/autoit] [autoit][/autoit] [autoit]

GUICtrlCreateGroup("Key", 15, 100, 230, 70)
GUICtrlCreateLabel("Choose the key which will get pressed.", 23, 122)
$Key = GUICtrlCreateCombo("Left", 23, 140, 75)
GUICtrlSetData(-1, "Right|Middle", "Left")

[/autoit] [autoit][/autoit] [autoit]

GUICtrlCreateGroup("Clicks", 260, 15, 125, 70)
$1Click = GUICtrlCreateRadio("1 Click", 267, 37)
GUICtrlSetState(-1, $GUI_CHECKED)
$2Click = GUICtrlCreateRadio("2 Click's", 267, 57)
$Start = GUICtrlCreateButton("Starten", 262, 105, 123, 65)
GuiCtrlSetOnEvent(-1, "Start")
GUISetState()

[/autoit] [autoit][/autoit] [autoit]

GUIRegisterMsg($WM_HSCROLL, "WM_HVSCROLL")

[/autoit] [autoit][/autoit] [autoit]

; #MAIN LOOP# ============================================================================
While 1
sleep(100)
WEnd

[/autoit] [autoit][/autoit] [autoit]

; #FUNCTIONS# ============================================================================
Func WM_HVSCROLL($hwnd, $iMsg, $wParam, $lParam) ; Slider
Local $hWndFrom, $iCode
If Not IsHWnd($Slider) Then $hWndCombo1 = GUICtrlGetHandle($Slider)
$hWndFrom = $lParam
$iCode = _WinAPI_HiWord ($wParam)
Switch $hWndFrom
Case $Slider, $hWndCombo1
GUICtrlSetData($label, "Speed = " & GUICtrlRead($slider))
EndSwitch
EndFunc ;==>WM_HVSCROLL

[/autoit] [autoit][/autoit] [autoit]

Func Start()
Global $Toggle = False
HotKeySet("{F6}", "_Get")
Do
TrayTip("Press" & " 'ESC' " & "to Exit.", "Press" & " 'F6' " & "to get the coordinates", 500)
sleep(500)
Until $Toggle = True
Exit
EndFunc

[/autoit] [autoit][/autoit] [autoit]

Func _Get()
$Pos = MouseGetPos()
$cFile = FileOpen(@ScriptDir & "\Mouseclick.au3", 1)
If BitAND(GUICtrlRead($1Click) = 1 Then
$clicks = 1
ElseIf BitAND(GUICtrlRead($2Click) = 1 Then
$clicks = 2
EndIf
FileWrite($cFile, "MouseClick('" & $Keys & "', " & $Pos[0] & ", " & $Pos[1] & ", " & $clicks & ", " & $Speed & ")" & @CRLF)
FileClose($cFile)
$Toggle = True
EndFunc

[/autoit] [autoit][/autoit] [autoit]

Func _Exit()
Exit
EndFunc

[/autoit]

**Schnuffel**

hab auch noch ein egekürzte Variante,
den HotKeySet brauchst Du nicht in der Schleife, genauso das FileOpen/Close
hab auch mal die sleep's angepasst.
das AdlibEnable brauchst Du auch nicht ...

Spoiler anzeigen

[autoit]

#include <GUIConstantsEx.au3>
#include <SliderConstants.au3>
#include <WindowsConstants.au3>
HotKeySet("{F6}", "_Get")
HotKeySet("{ESC}", "_Exit")
Global $Mfile = @ScriptDir & "\Mouseclick.au3", $Pos, $Toogle = 0
FileOpen($Mfile, 1)

[/autoit] [autoit][/autoit] [autoit]

; Gui -->
$Options = GUICreate("Options", 400, 190)
GUISetBkColor(0x00E0FFFF) ; will change background color
GUICtrlCreateGroup("Speed", 15, 15, 230, 70)
$label = GUICtrlCreateLabel("Speed = 45", 23, 37)
$slider = GUICtrlCreateSlider(23, 57, 200, 20, BitOR($TBS_AUTOTICKS, $WS_BORDER))
GUICtrlSetState(-1, $Gui_FOCUS)
GUICtrlSetLimit(-1, 100, 0) ; change min/max value
GUICtrlCreateGroup("Key", 15, 100, 230, 70)
GUICtrlCreateLabel("Choose the key which will get pressed.", 23, 122)
$Key = GUICtrlCreateCombo("Left", 23, 140, 75)
GUICtrlSetData(-1, "Right|Middle", "Left") ; add other item snd set a new default
GUICtrlSetData($slider, 10) ; set cursor
GUICtrlCreateGroup("Clicks", 260, 15, 125, 70)
$1Click = GUICtrlCreateRadio("1 Click", 267, 37)
GUICtrlSetState(-1, $GUI_CHECKED)
$2Click = GUICtrlCreateRadio("2 Click's", 267, 57)
$Start = GUICtrlCreateButton("Starten", 262, 105, 123, 65)
GUISetState()
;==>
; Schleife für die Gui
While 1
$nMsg = GUIGetMsg()
Switch $nMsg
Case $Start
$Speed = GUICtrlRead($slider)
$Keys = GUICtrlRead($Key)
$1 = GUICtrlRead($1Click)
$2 = GUICtrlRead($2Click)
GUIDelete()
_getPos()
EndSwitch
sleep(50)
GUICtrlSetData($label, "Speed = " & GUICtrlRead($slider))
WEnd
;==>
; Wartet bis F6 Gedrückt wird und Zeigt einen TrayTip an
Func _getPos()
TrayTip("Press" & " 'ESC' " & "to Exit.", "Press" & " 'F6' " & "to get the coordinates", 500)
EndFunc
;==>_getPos
; Checkt alle Daten und schreibt sie in die Datei
Func _Get()
$Pos = MouseGetPos()
If $1 = $GUI_CHECKED Then
$clicks = 1
ElseIf $2 = $GUI_CHECKED Then
$clicks = 2
EndIf
FileWrite($MFile, "MouseClick('" & $Keys & "', " & $Pos[0] & ", " & $Pos[1] & ", " & $clicks & ", " & $Speed & ")" & @CRLF)
EndFunc
;==>_Get
; Beendet das Script
Func _Exit()
FileClose($MFile)
Exit
EndFunc
;==>_Exit

[/autoit]

SiLenCa

So, danke an euch beiden erst einmal.
Schnuffel, deins funktioniert nicht so ganz wie ich es vorher hatte. Bei Tastendruck auf F6 soll er Koordinate nehmen, in Datei schreiben und das Script beenden.

@ChaosKeks, bei deinem Script habe ich nen Problem.
hier Fehlermeldung:

Spoiler anzeigen

C:\Dokumente und Einstellungen\NeMiTz\Desktop\Checksum - Mouseclick - My UDF\Source\Get_MouseClick.au3(62,40) : ERROR: syntax error
If BitAND(GUICtrlRead($1Click) = 1 Then
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^
C:\Dokumente und Einstellungen\NeMiTz\Desktop\Checksum - Mouseclick - My UDF\Source\Get_MouseClick.au3(64,38) : ERROR: BitAND() [built-in] called with wrong number of args.
ElseIf BitAND(GUICtrlRead($2Click)
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^
C:\Dokumente und Einstellungen\NeMiTz\Desktop\Checksum - Mouseclick - My UDF\Source\Get_MouseClick.au3(67,46) : WARNING: $Keys: possibly used before declaration.
FileWrite($cFile, "MouseClick('" & $Keys &
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^
C:\Dokumente und Einstellungen\NeMiTz\Desktop\Checksum - Mouseclick - My UDF\Source\Get_MouseClick.au3(67,114) : WARNING: $Speed: possibly used before declaration.
FileWrite($cFile, "MouseClick('" & $Keys & "', " & $Pos[0] & ", " & $Pos[1] & ", " & $clicks & ", " & $Speed &
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^
C:\Dokumente und Einstellungen\NeMiTz\Desktop\Checksum - Mouseclick - My UDF\Source\Get_MouseClick.au3(67,46) : ERROR: $Keys: undeclared global variable.
FileWrite($cFile, "MouseClick('" & $Keys &
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^
C:\Dokumente und Einstellungen\NeMiTz\Desktop\Checksum - Mouseclick - My UDF\Source\Get_MouseClick.au3 - 3 error(s), 2 warning(s)

Die Deklarationen kann ich ja noch machen, aber es scheint auch nen Problem mit BitAnd zu geben weiss aber nicht wodran es liegt

ChaosKeks

Ups Ja, mein Fehler -> Da die Gui schon gelöscht wurde konnten die Radiofelder nicht mehr gelesen werden...

So sollte es gehen:

Spoiler anzeigen

[autoit]

#include <GUIConstantsEx.au3>
#include <SliderConstants.au3>
#include <WindowsConstants.au3>
#include <WinApi.au3>

[/autoit] [autoit][/autoit] [autoit]

Opt("GuiOnEventMode",1)
; #GUI# =================================================================================
$Options = GUICreate("Options", 400, 190)
GUISetBkColor(0x00E0FFFF)
GuiSetOnEvent($GUI_EVENT_CLOSE, "_Exit")

[/autoit] [autoit][/autoit] [autoit]

GUICtrlCreateGroup("Speed", 15, 15, 230, 70)
$label = GUICtrlCreateLabel("Speed = 45", 23, 37)
$slider = GUICtrlCreateSlider(23, 57, 200, 20, BitOR($TBS_AUTOTICKS, $WS_BORDER))
GUICtrlSetData($slider, 45)

[/autoit] [autoit][/autoit] [autoit]

GUICtrlCreateGroup("Key", 15, 100, 230, 70)
GUICtrlCreateLabel("Choose the key which will get pressed.", 23, 122)
$Key = GUICtrlCreateCombo("Left", 23, 140, 75)
GUICtrlSetData(-1, "Right|Middle", "Left")

[/autoit] [autoit][/autoit] [autoit]

GUICtrlCreateGroup("Clicks", 260, 15, 125, 70)
$1Click = GUICtrlCreateRadio("1 Click", 267, 37)
GUICtrlSetState(-1, $GUI_CHECKED)
$2Click = GUICtrlCreateRadio("2 Click's", 267, 57)
$Start = GUICtrlCreateButton("Starten", 262, 105, 123, 65)
GuiCtrlSetOnEvent(-1, "Start")
GUISetState()

[/autoit] [autoit][/autoit] [autoit]

GUIRegisterMsg($WM_HSCROLL, "WM_HVSCROLL")

[/autoit] [autoit][/autoit] [autoit]

; #MAIN LOOP# ============================================================================
While 1
sleep(100)
WEnd

[/autoit] [autoit][/autoit] [autoit]

; #FUNCTIONS# ============================================================================
Func WM_HVSCROLL($hwnd, $iMsg, $wParam, $lParam) ; Slider
Local $hWndFrom, $iCode
If Not IsHWnd($Slider) Then $hWndCombo1 = GUICtrlGetHandle($Slider)
$hWndFrom = $lParam
$iCode = _WinAPI_HiWord ($wParam)
Switch $hWndFrom
Case $Slider, $hWndCombo1
GUICtrlSetData($label, "Speed = " & GUICtrlRead($slider))
EndSwitch
EndFunc ;==>WM_HVSCROLL

[/autoit] [autoit][/autoit] [autoit]

Func Start()
Global $Toggle = False, $clicks, $Keys, $speed
HotKeySet("{F6}", "_Get")
$Keys = GUICtrlRead($Key)
$Speed = GUICtrlRead($slider)
If BitAND(GUICtrlRead($1Click),$GUI_CHECKED) = 1 Then
$clicks = 1
ElseIf BitAND(GUICtrlRead($2Click),$GUI_CHECKED) = 1 Then
$clicks = 2
EndIf
GuiDelete()
Do
TrayTip("Press" & " 'ESC' " & "to Exit.", "Press" & " 'F6' " & "to get the coordinates", 500)
sleep(500)
Until $Toggle = True
Exit
EndFunc

[/autoit] [autoit][/autoit] [autoit]

Func _Get()
$Pos = MouseGetPos()
$cFile = FileOpen(@ScriptDir & "\Mouseclick.au3", 1)
FileWrite($cFile, "MouseClick('" & $Keys & "', " & $Pos[0] & ", " & $Pos[1] & ", " & $clicks & ", " & $Speed & ")" & @CRLF)
FileClose($cFile)
$Toggle = True
EndFunc

[/autoit] [autoit][/autoit] [autoit]

Func _Exit()
Exit
EndFunc

[/autoit]

SiLenCa

Jo super, hattest noch vergessen, das $speed auszulesen... habs noch hinzugefügt und nen Schönheitsfehler beim ersten Label vorgenommen.
Hier der Code:

Spoiler anzeigen

[autoit]

#include <GUIConstantsEx.au3>
#include <SliderConstants.au3>
#include <WindowsConstants.au3>
#include <WinApi.au3>

[/autoit] [autoit][/autoit] [autoit]

Global $Keys, $clicks, $Speed

[/autoit] [autoit][/autoit] [autoit]

Opt("GuiOnEventMode",1)
; #GUI# =================================================================================
$Options = GUICreate("Options", 400, 190)
GUISetBkColor(0x00E0FFFF)
GuiSetOnEvent($GUI_EVENT_CLOSE, "_Exit")

[/autoit] [autoit][/autoit] [autoit]

GUICtrlCreateGroup("Speed", 15, 15, 230, 70)
$label = GUICtrlCreateLabel("Speed = 10", 23, 37,"",15)
$slider = GUICtrlCreateSlider(23, 57, 200, 20, BitOR($TBS_AUTOTICKS, $WS_BORDER))
GUICtrlSetData($slider, 10)
GUICtrlSetState(-1,$GUI_FOCUS)

[/autoit] [autoit][/autoit] [autoit]

GUICtrlCreateGroup("Key", 15, 100, 230, 70)
GUICtrlCreateLabel("Choose the key which will get pressed.", 23, 122)
$Key = GUICtrlCreateCombo("Left", 23, 140, 75)
GUICtrlSetData(-1, "Right|Middle", "Left")

[/autoit] [autoit][/autoit] [autoit]

GUICtrlCreateGroup("Clicks", 260, 15, 125, 70)
$1Click = GUICtrlCreateRadio("1 Click", 267, 37)
GUICtrlSetState(-1, $GUI_CHECKED)
$2Click = GUICtrlCreateRadio("2 Click's", 267, 57)
$Start = GUICtrlCreateButton("Starten", 262, 105, 123, 65)
GuiCtrlSetOnEvent(-1, "Start")
GUISetState()

[/autoit] [autoit][/autoit] [autoit]

GUIRegisterMsg($WM_HSCROLL, "WM_HVSCROLL")

[/autoit] [autoit][/autoit] [autoit]

; #MAIN LOOP# ============================================================================
While 1
sleep(100)
WEnd

[/autoit] [autoit][/autoit] [autoit]

; #FUNCTIONS# ============================================================================
Func WM_HVSCROLL($hwnd, $iMsg, $wParam, $lParam) ; Slider
Local $hWndFrom, $iCode
If Not IsHWnd($Slider) Then $hWndCombo1 = GUICtrlGetHandle($Slider)
$hWndFrom = $lParam
$iCode = _WinAPI_HiWord ($wParam)
Switch $hWndFrom
Case $Slider, $hWndCombo1
GUICtrlSetData($label, "Speed = " & GUICtrlRead($slider))
EndSwitch
EndFunc ;==>WM_HVSCROLL

[/autoit] [autoit][/autoit] [autoit]

Func Start()
Global $Toggle = False, $clicks
HotKeySet("{F6}", "_Get")
$Speed = GUICtrlRead($slider)
If BitAND(GUICtrlRead($1Click),$GUI_CHECKED) = 1 Then
$clicks = 1
ElseIf BitAND(GUICtrlRead($2Click),$GUI_CHECKED) = 1 Then
$clicks = 2
EndIf
GuiDelete()
Do
TrayTip("Press" & " 'ESC' " & "to Exit.", "Press" & " 'F6' " & "to get the coordinates", 500)
sleep(500)
Until $Toggle = True
Exit
EndFunc

[/autoit] [autoit][/autoit] [autoit]

Func _Get()
$Pos = MouseGetPos()
$cFile = FileOpen(@ScriptDir & "\Mouseclick.au3", 1)
FileWrite($cFile, "MouseClick('" & $Keys & "', " & $Pos[0] & ", " & $Pos[1] & ", " & $clicks & ", " & $Speed & ")" & @CRLF)
FileClose($cFile)
$Toggle = True
EndFunc

[/autoit] [autoit][/autoit] [autoit]

Func _Exit()
Exit
EndFunc

[/autoit]

**Schnuffel**

sorry, musste halt Dein exit wieder aktivieren ...

ChaosKeks

Das mit Speed hatte ich schon längst dazueditiert und das mitm Label kam bei deinem ersten Script nicht kla rüber ;P

Wie?Wo?Was? Schnuffel... welches Exit?

SiLenCa

Ahso, hatte den Edit wohl nicht ganz mitbekommen Vielen dank erstmal, ist genau wie ich es mir vorgestellt hatte.